test/go.mod (2)

1-3: Use a unique module path and pin toolchain (optional but recommended)

“module test” is ambiguous; prefer the repo path. Also consider a toolchain line for reproducibility.

-module test
+module github.com/cloudposse-terraform-components/aws-elasticsearch/test

 go 1.23.0
+
+toolchain go1.23.0

Ensure CI installs Go 1.23.x (or update toolchain to match your runner).

---

35-35: Remove unnecessary docdb direct dependency

Verification confirms docdb is not actively imported—only a commented-out reference exists in test/component_test.go. The direct dependency in test/go.mod can be safely removed.

-	github.com/aws/aws-sdk-go-v2/service/docdb v1.40.10

src/main.tf (1)

79-80: Incorrect SSM parameter description

The description references Aurora Postgres; this parameter stores the Elasticsearch admin password.

-  description = "Primary Aurora Postgres Password for the master DB user"
+  description = "Elasticsearch admin password for the master user"

test/component_test.go (5)

27-29: Assert NotEmpty for AWS account ID

accountId is a string; NotNil always passes. Use NotEmpty.

-	assert.NotNil(s.T(), accountId)
+	assert.NotEmpty(s.T(), accountId)

---

33-34: Handle DeployAtmosComponent error

Ignoring the error can mask real failures.

-	options, _ := s.DeployAtmosComponent(s.T(), component, stack, &inputs)
-	assert.NotNil(s.T(), options)
+	options, err := s.DeployAtmosComponent(s.T(), component, stack, &inputs)
+	assert.NoError(s.T(), err)
+	assert.NotNil(s.T(), options)

---

39-47: Reduce brittle string expectations

Hard-coded prefixes (e.g., “eg-default-ue2-test-e-”) make tests fragile across naming tweaks. Prefer asserting stable ARN/endpoint shapes and substrings.

Example:

-	assert.True(s.T(), strings.HasPrefix(domainArn, fmt.Sprintf("arn:aws:es:%s:%s:domain/eg-default-ue2-test-e-", awsRegion, accountId)))
+	assert.True(s.T(), strings.HasPrefix(domainArn, fmt.Sprintf("arn:aws:es:%s:%s:domain/", awsRegion, accountId)))
+	assert.Contains(s.T(), domainArn, ":domain/")

Apply similar loosening to domainEndpoint/kibanaEndpoint/domainHostname checks.

---

63-65: Avoid exact match on SSM key; assert prefix/suffix

Exact equality ties the test to the component name. Prefer prefix/suffix.

-	assert.Equal(s.T(), masterPasswordSSMKey, "/elasticsearch/e/password")
+	assert.True(s.T(), strings.HasPrefix(masterPasswordSSMKey, "/elasticsearch/"))
+	assert.True(s.T(), strings.HasSuffix(masterPasswordSSMKey, "/password"))

---

3-16: Drop commented imports

Remove commented imports to keep the file clean.

-	//"context"
-	// "github.com/aws/aws-sdk-go-v2/service/docdb"
-	// awshelper "github.com/cloudposse/test-helpers/pkg/aws"

test/fixtures/stacks/catalog/account-map.yaml (1)

23-46: Static backend config looks fine; ensure TEST_ACCOUNT_ID is set in CI

The static backend depends on TEST_ACCOUNT_ID for role resolution. Make sure your pipeline exports it.

test/fixtures/vendor.yaml (1)

7-54: Pin sources to immutable SHAs (optional)

Tags can be moved; pinning to commit SHAs improves supply‑chain reproducibility. Keep the tag in a comment for readability.

Example:

source: github.com/cloudposse-terraform-components/aws-dns-delegated.git//src?ref=abcdef1234567890 # v1.535.1

test/fixtures/stacks/orgs/default/test/_defaults.yaml (1)

8-9: Consider absolute or environment-aware paths for Terraform state backend.

The local backend configuration uses relative paths with template defaults. While this works for test fixtures, relative paths can cause issues when the working directory varies across execution contexts. Ensure all test invocations execute from the expected directory, or document this requirement clearly.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro